summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorpennae <github@quasiparticle.net>2022-07-17 09:47:33 +0200
committerpennae <github@quasiparticle.net>2022-07-17 17:23:52 +0200
commitd4ed52e48eb52566dab91080eb25d8979fbb7d3e (patch)
tree5380dbf07454fa28f78ece9d1c262cc8bab00316 /src
parentaa3bc5459b58d6e3897d3cef8ae07d3c35d9e2a9 (diff)
downloadminor-skulk-d4ed52e48eb52566dab91080eb25d8979fbb7d3e.tar.gz
minor-skulk-d4ed52e48eb52566dab91080eb25d8979fbb7d3e.tar.xz
minor-skulk-d4ed52e48eb52566dab91080eb25d8979fbb7d3e.zip
remove zeroize dependency
this is not so much a problem as a possible source of false security for the readers. all secret keys we handle are serialized in some form, and those serialization buffers are *not* zeroed out after use. zeroing our raw buffers doesn't help much in that case, using a zero-on-free allocator would be much more helpful.
Diffstat (limited to 'src')
-rw-r--r--src/crypto.rs9
1 files changed, 1 insertions, 8 deletions
diff --git a/src/crypto.rs b/src/crypto.rs
index 049f6b0..c3417fd 100644
--- a/src/crypto.rs
+++ b/src/crypto.rs
@@ -17,16 +17,10 @@ use sha2::Sha256;
const NAMESPACE: &[u8] = b"identity.mozilla.com/picl/v1/";
-#[derive(Clone, PartialEq, Eq, Zeroize, Serialize, Deserialize)]
+#[derive(Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(try_from = "String", into = "String")]
pub struct SecretBytes<const N: usize>(pub [u8; N]);
-impl<const N: usize> Drop for SecretBytes<N> {
- fn drop(&mut self) {
- self.zeroize();
- }
-}
-
#[derive(Clone, PartialEq, Eq)]
pub struct TokenID(pub [u8; 32]);
@@ -123,7 +117,6 @@ mod from_hkdf {
}
use from_hkdf::from_hkdf;
-use zeroize::Zeroize;
impl<const N: usize> SecretBytes<N> {
pub fn generate() -> Self {